Add RKE2 boostrap provider to e2e #177
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-demicev
force-pushed
the
rke2
branch
2 times, most recently
from
b5a0d87
to
ddb8cc2
Compare
salasberryfin
previously approved these changes
Oct 2, 2023
richardcase
reviewed
Oct 3, 2023
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
alexander-demicev
force-pushed
the
rke2
branch
2 times, most recently
from
e08bca3
to
88e95cf
Compare
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
alexander-demicev
force-pushed
the
rke2
branch
from
88e95cf
to
717d614
Compare
richardcase
reviewed
Dec 4, 2023
There was a problem hiding this comment.
Seems good to me.
@alexander-demicev - when you get some time could you rebase this?
| fetchConfig: | ||
| url: https://github.com/rancher-sandbox/cluster-api-provider-rke2/releases/v0.1.1/bootstrap-components.yaml | ||
| version: v0.1.1 |
There was a problem hiding this comment.
We can update to use v0.2.2 now.
|
Looks like this needs a rebase. |
|
@alexander-demicev beta release of CAPI is out https://github.com/kubernetes-sigs/cluster-api/releases/tag/v1.7.0-beta.0, let's rebase this and get going? |
|
closing in favor of #177 |
auto-merge was automatically disabled
April 29, 2024 09:35
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Special notes for your reviewer:
Checklist: